Add Pixel 10a mobile performance coverage - #5284
Open
LoopedBard3 wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the repo’s mobile performance infrastructure to include Pixel 10a alongside existing Pixel coverage by introducing a new Helix queue mapping and wiring a machinePool value through pipeline/job matrices.
Changes:
- Added a new logical-machine → Helix queue mapping for
perfpixel10aand treated the new Pixel 10a queue as a mobile queue for device-name env var handling. - Updated Helix/pipeline templates and matrices to pass
machinePool(e.g.,Pixel8,Pixel10a) and schedule Pixel 10a runs across existing SDK/MAUI matrices. - Refactored runtime Android perf jobs to iterate over a configurable
androidMachineslist (Pixel + Pixel 10a).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/run_performance_job.py | Adds Pixel 10a queue mapping and includes the queue in mobile DEVICE_NAME handling. |
| helix.yml | Adds machinePool variable and a Pixel 10a profile that passes --machine-pool. |
| eng/pipelines/templates/run-performance-job.yml | Updates the machinePool parameter comment to include Pixel 10a. |
| eng/pipelines/templates/build-machine-matrix.yml | Adds a private-build machine matrix entry for Pixel 10a with machinePool: Pixel10a. |
| eng/pipelines/sdk-perf-jobs.yml | Adds the Pixel 10a machine to multiple existing SDK scenario matrices. |
| eng/pipelines/runtime-perf-jobs.yml | Introduces androidMachines and loops Android runtime perf jobs over Pixel + Pixel 10a. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (2)
eng/pipelines/templates/build-machine-matrix.yml:137
- The comment says "Windows ARM64 Pixel 10a", but this matrix entry is using
archType: x64andvmImage: windows-2022(Windows x64 host) and targets an Android ARM64 device. This can mislead future edits/debugging.
- ${{ if and(containsValue(parameters.buildMachines, 'win-x64-android-arm64-pixel10a'), not(eq(parameters.isPublic, true))) }}: # Windows ARM64 Pixel 10a only used in private builds currently
scripts/run_performance_job.py:1151
- The Pixel 10a DEVICE_NAME special-case is unnecessarily tied to both
logical_machineand the queue string. If a Pixel 10a run is configured via--queue Windows.11.Amd64.Pixel.10.Perf(without--logical-machine/--machine-pool),DEVICE_NAMEwill not be set even though this queue is treated as a mobile queue below.
# Pixel 10a runtime jobs use a logical machine rather than a machine pool.
if args.logical_machine == "perfpixel10a" and args.queue == "Windows.11.Amd64.Pixel.10.Perf":
args.run_env_vars["DEVICE_NAME"] = "Pixel10a"
elif args.machine_pool and args.queue and args.queue in (
"Windows.11.Amd64.Pixel.Perf",
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Author
|
While this PR is good, there are some on machine changes that need to be made to get these devices fully working, so waiting on those changes before merging. |
DrewScoggins
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pixel10adevice name while preserving Pixel 8 coverageTesting
Internal Run: https://dev.azure.com/dnceng/internal/_build/results?buildId=3052379&view=results